fix review: debug leak, int crash, rank mismatch, 0-byte skip, log cap, understand diag

app.py

@@ -143,7 +143,7 @@ def _caption_via_understand(audio_path, timeout=120):
             timeout=30,
         )
         if r.status_code != 200:
-            logger.warning("[Caption] %s: /understand returned %d", fname, r.status_code)
+            logger.warning("[Caption] %s: /understand returned %d: %s", fname, r.status_code, r.text[:200])
             return None
         job_id = r.json().get("id")
         if not job_id:
@@ -185,14 +185,17 @@ def _run_pipeline(caption, lyrics, bpm, duration, seed, steps, output_format,
     req = {"caption": caption or "upbeat electronic dance music"}
     req["lyrics"] = lyrics if lyrics and lyrics.strip() else "[Instrumental]"
 
-    if bpm and int(bpm) > 0:
-        req["bpm"] = int(bpm)
-    if duration and float(duration) > 0:
-        req["duration"] = min(float(duration), 300)
-    if seed is not None and int(seed) >= 0:
-        req["seed"] = int(seed)
-    if steps and int(steps) > 0:
-        req["inference_steps"] = int(steps)
+    try:
+        if bpm and int(float(bpm)) > 0:
+            req["bpm"] = int(float(bpm))
+        if duration and float(duration) > 0:
+            req["duration"] = min(float(duration), 300)
+        if seed is not None and int(float(seed)) >= 0:
+            req["seed"] = int(float(seed))
+        if steps and int(float(steps)) > 0:
+            req["inference_steps"] = int(float(steps))
+    except (ValueError, TypeError):
+        pass
     if adapter:
         req["adapter"] = adapter
     if lm_model:
@@ -557,6 +560,8 @@ def gradio_main():
 
         def _log(msg):
             _train_log_lines.append(msg)
+            if len(_train_log_lines) > 2000:
+                _train_log_lines[:] = _train_log_lines[-1000:]
 
         def _log_text():
             return "\n".join(_train_log_lines)
@@ -577,7 +582,7 @@ def gradio_main():
 
         epochs = max(1, min(int(epochs), 1000))
         lr = float(lr)
-        rank = max(1, min(int(rank), 64))
+        rank = max(1, min(int(rank), 128))
 
         work_dir = os.path.join(OUTPUT_DIR, "train_workspace", lora_name)
         os.makedirs(work_dir, exist_ok=True)
@@ -602,6 +607,9 @@ def gradio_main():
                 dur = _lr.get_duration(path=src)
             except Exception:
                 dur = 0.0
+            if dur <= 0:
+                skipped_names.append(f"{fname} (invalid/empty)")
+                continue
             remaining = MAX_TOTAL_AUDIO - total_dur
             if remaining <= 0:
                 skipped_names.append(fname)
@@ -765,12 +773,10 @@ def gradio_main():
                 _log("[OK] ace-server restarted successfully")
             else:
                 _log("[WARN] ace-server may not have restarted -- check logs")
-            # Debug: list what's in the adapter directory
             if os.path.isdir(adapter_out):
-                contents = os.listdir(adapter_out)
-                _log(f"[DEBUG] Adapter dir {adapter_out}: {contents}")
+                logger.info("Adapter dir %s: %s", adapter_out, os.listdir(adapter_out))
             else:
-                _log(f"[DEBUG] Adapter dir {adapter_out} does NOT exist!")
+                logger.warning("Adapter dir %s does not exist", adapter_out)
             adapter_safetensors = os.path.join(adapter_out, "adapter_model.safetensors")
             if os.path.isfile(adapter_safetensors):
                 # Copy to a temp file so Gradio doesn't try to validate /app paths